search

open-telemetry / opentelemetry-php

The OpenTelemetry PHP Library
https://opentelemetry.io/docs/instrumentation/php/
Apache License 2.0
756 stars 187 forks source link

New Labels Request - `sampler: aws:xray`, `propagator: aws:xray`, and `id-generator: aws:xray` #1372

Open mxiamxia opened 2 months ago

mxiamxia commented 2 months ago

Hello, I'm reaching out on behalf of the AWS X-Ray team. We would like to request the addition of new labels to php-contrib repository: sampler: aws:xray, propagator: aws:xray, and id-generator: aws:xray. These labels would be used for PRs and issues pertaining to the X-Ray Sampler, X-Ray Propagator, and X-Ray ID Generator. Ideally, there would be automation that adds these labels to PRs touching X-Ray component code - we would be happy to help with this if some guidance was provided.

Our goal is to have labelling across open-telemetry repositories so that we can find PRs and issues related to the X-Ray components and give faster support to the OTEL community.

Thank you.

brettmc commented 2 months ago

Hi @mxiamxia I've created those labels in both our main and contrib repos (since issues are only created in the main repo). There is no automation, so yes I'd like some guidance there.

Annosha commented 1 month ago

Hi @brettmc if this issue is still open I would like to work on it?

brettmc commented 1 month ago

Hi @Annosha you are welcome to work on this. If you do find a good way to automatically label issues/PRs, the project would be interested in something that can be applied more generally than just to x-ray.

Annosha commented 1 month ago

@brettmc I have few approaches in mind:

  1. GitHub Actions: We could create a GitHub Action that listens for issue or PR events and applies labels based on keywords like “xray” or “aws”. This would involve creating a YAML file in the .github/workflows directory to handle the logic, making it adaptable for different keywords.

  2. Probot or GitHub App: Another option is using Probot, a GitHub App framework that could offer more customizable automation, like scanning issue content for specific terms, or automatically labeling issues or PRs if certain files are modified (e.g., code related to X-Ray integrations).

  3. Existing Labeling Bots: There are labeling bots, like GitHub's Issue Label Bot and Issue Label Bot Pro, that may offer configurable solutions for keyword-based or pattern-based auto-labeling.

Could you advise on which option might be more reliable? If you have other recommendations, please let me know.