open-telemetry / opentelemetry-php

The OpenTelemetry PHP Library
https://opentelemetry.io/docs/instrumentation/php/
Apache License 2.0
752 stars 186 forks source link

Add `TextMapPropagator` to instrumentation context #1401

Closed Nevay closed 1 month ago

Nevay commented 1 month ago

Necessary for HTTP instrumentations etc.

netlify[bot] commented 1 month ago

Deploy Preview for opentelemetry-php canceled.

Name Link
Latest commit 28a91dcb8490d9206c0c065d1310057281f50c19
Latest deploy log https://app.netlify.com/sites/opentelemetry-php/deploys/670bebaaf536fc000812b4bc
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 73.69%. Comparing base (cd8c0e3) to head (28a91dc). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...c/SDK/Propagation/LateBindingTextMapPropagator.php 0.00% 13 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401/graphs/tree.svg?width=650&height=150&src=pr&token=OE661REHqm&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #1401 +/- ## ============================================ - Coverage 73.85% 73.69% -0.17% - Complexity 2672 2680 +8 ============================================ Files 386 387 +1 Lines 7650 7668 +18 ============================================ + Hits 5650 5651 +1 - Misses 2000 2017 +17 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [8.1](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `73.33% <38.09%> (-0.18%)` | :arrow_down: | | [8.2](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `73.56% <38.09%> (-0.26%)` | :arrow_down: | | [8.3](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `73.60% <38.09%> (-0.05%)` | :arrow_down: | | [8.4](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `73.57% <38.09%> (-0.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...PI/Instrumentation/AutoInstrumentation/Context.php](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401?src=pr&el=tree&filepath=src%2FAPI%2FInstrumentation%2FAutoInstrumentation%2FContext.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL0FQSS9JbnN0cnVtZW50YXRpb24vQXV0b0luc3RydW1lbnRhdGlvbi9Db250ZXh0LnBocA==) | `100.00% <ø> (ø)` | | | [src/SDK/SdkAutoloader.php](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401?src=pr&el=tree&filepath=src%2FSDK%2FSdkAutoloader.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL1NESy9TZGtBdXRvbG9hZGVyLnBocA==) | `93.91% <100.00%> (+0.39%)` | :arrow_up: | | [...c/SDK/Propagation/LateBindingTextMapPropagator.php](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401?src=pr&el=tree&filepath=src%2FSDK%2FPropagation%2FLateBindingTextMapPropagator.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL1NESy9Qcm9wYWdhdGlvbi9MYXRlQmluZGluZ1RleHRNYXBQcm9wYWdhdG9yLnBocA==) | `0.00% <0.00%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry). Last update [cd8c0e3...28a91dc](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1401?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry).