open-telemetry / opentelemetry-php

The OpenTelemetry PHP Library
https://opentelemetry.io/docs/instrumentation/php/
Apache License 2.0
752 stars 186 forks source link

add sdk-config 0.3 support for key/value headers and attributes #1428

Open brettmc opened 2 weeks ago

brettmc commented 2 weeks ago

Related: #1423

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (8857b0c) to head (35216e7).

Files with missing lines Patch % Lines
.../Config/SDK/ComponentProvider/OpenTelemetrySdk.php 0.00% 13 Missing :warning:
...K/ComponentProvider/Logs/LogRecordExporterOtlp.php 0.00% 9 Missing :warning:
...K/ComponentProvider/Metrics/MetricExporterOtlp.php 0.00% 9 Missing :warning:
...g/SDK/ComponentProvider/Trace/SpanExporterOtlp.php 0.00% 9 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428/graphs/tree.svg?width=650&height=150&src=pr&token=OE661REHqm&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #1428 +/- ## ============================================ - Coverage 73.59% 73.26% -0.34% Complexity 2685 2685 ============================================ Files 387 387 Lines 7977 8009 +32 ============================================ - Hits 5871 5868 -3 - Misses 2106 2141 +35 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [8.1](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `72.96% <0.00%> (-0.27%)` | :arrow_down: | | [8.2](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `73.16% <0.00%> (-0.40%)` | :arrow_down: | | [8.3](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `73.21% <0.00%> (-0.29%)` | :arrow_down: | | [8.4](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `73.21% <0.00%> (-0.29%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...K/ComponentProvider/Logs/LogRecordExporterOtlp.php](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428?src=pr&el=tree&filepath=src%2FConfig%2FSDK%2FComponentProvider%2FLogs%2FLogRecordExporterOtlp.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL0NvbmZpZy9TREsvQ29tcG9uZW50UHJvdmlkZXIvTG9ncy9Mb2dSZWNvcmRFeHBvcnRlck90bHAucGhw) | `0.00% <0.00%> (ø)` | | | [...K/ComponentProvider/Metrics/MetricExporterOtlp.php](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428?src=pr&el=tree&filepath=src%2FConfig%2FSDK%2FComponentProvider%2FMetrics%2FMetricExporterOtlp.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL0NvbmZpZy9TREsvQ29tcG9uZW50UHJvdmlkZXIvTWV0cmljcy9NZXRyaWNFeHBvcnRlck90bHAucGhw) | `0.00% <0.00%> (ø)` | | | [...g/SDK/ComponentProvider/Trace/SpanExporterOtlp.php](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428?src=pr&el=tree&filepath=src%2FConfig%2FSDK%2FComponentProvider%2FTrace%2FSpanExporterOtlp.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL0NvbmZpZy9TREsvQ29tcG9uZW50UHJvdmlkZXIvVHJhY2UvU3BhbkV4cG9ydGVyT3RscC5waHA=) | `0.00% <0.00%> (ø)` | | | [.../Config/SDK/ComponentProvider/OpenTelemetrySdk.php](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428?src=pr&el=tree&filepath=src%2FConfig%2FSDK%2FComponentProvider%2FOpenTelemetrySdk.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL0NvbmZpZy9TREsvQ29tcG9uZW50UHJvdmlkZXIvT3BlblRlbGVtZXRyeVNkay5waHA=) | `0.00% <0.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry). Last update [8857b0c...35216e7](https://app.codecov.io/gh/open-telemetry/opentelemetry-php/pull/1428?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry).
brettmc commented 4 days ago

@open-telemetry/php-approvers I think this is ready for review now.