Closed jspaetzel closed 1 week ago
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.
Will follow-up on CLA asap
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.66%. Comparing base (
38633fb
) to head (0fb4683
). Report is 1 commits behind head on main.
@jspaetzel can you run php-cs-fixer to resolve its complaint? Otherwise LGTM and just waiting on CLA to be signed :)
:heavy_check_mark: Thanks y'all!
There's other circumstances besides is_file && is_readable when file_get_contents may return false. This is a defensive change to prevent TypeErrors when calling trim()