Replace current time implementation with hrtime

open-telemetry / opentelemetry-php

The OpenTelemetry PHP Library

https://opentelemetry.io/docs/instrumentation/php/

Apache License 2.0

716 stars 178 forks source link

Replace current time implementation with hrtime #73

Closed bobstrecansky closed 4 years ago

bobstrecansky commented 4 years ago

We'd like to replace our current time implementation with php's hrtime function.

https://www.php.net/manual/en/function.hrtime.php

Todo for this:

[x] update dependencies to PHP 7.3
[ ] replace current time implementation with calls to hrtime

bobstrecansky commented 4 years ago

Working through this first with https://github.com/open-telemetry/opentelemetry-php/pull/83

bobstrecansky commented 4 years ago

This should be a relatively low lift ticket, and would be good for someone who is trying to get acclimated with the codebase.

We went though and replaced string instances of time with integer times. Plumbing was also created to use a monotonic timer for Span duration, but has not yet been implemented.

bobstrecansky commented 4 years ago

This has been completed with #153