search

open-telemetry / opentelemetry-proto

OpenTelemetry protocol (OTLP) specification and Protobuf definitions
https://opentelemetry.io/docs/specs/otlp/
Apache License 2.0
576 stars 253 forks source link

Fix LogRecordFlags and DataPointFlags enum element name inconsistency #474

Closed tigrannajaryan closed 1 year ago

tigrannajaryan commented 1 year ago

Other enum element names in this repo are prefixed by enum name in CAPITAL_CASE.

This change makes naming of LogRecordFlags and DataPointFlags elements consistent with the rest of the enums.

Resolves https://github.com/open-telemetry/opentelemetry-proto/issues/473

@open-telemetry/specs-approvers this breaks generated code. We are allowed to make such breaking changes, but I want us to be aware that we are causing some pain and only make this change if we think it is worth it. I would want to see a majority of TC approving this before I merge. I can personally argue both ways and do not see the definite argument to make up my mind.

dyladan commented 1 year ago

I would want to see a majority of TC approving this before I merge

Since this is such a high bar should we set some deadline so it doesn't sit forever? There may be TC members who don't feel strongly enough to block it but also don't want to approve it.

tigrannajaryan commented 1 year ago

We have enough approvals. I am going to keep it open for another day (2 day rule) and then will merge.