search

open-telemetry / opentelemetry-proto

OpenTelemetry protocol (OTLP) specification and Protobuf definitions
https://opentelemetry.io/docs/specs/otlp/
Apache License 2.0
607 stars 262 forks source link

AnyValue diverging from spec on website #501

Closed bripkens closed 1 year ago

bripkens commented 1 year ago

Hey folks,

we noticed that the documentation on the OTel website for attributes and the OTLP definition for AnyValue are slightly different. More specifically, OTLP accepts a wider range of values – specifically bytes and KeyValueList. Consequently, some questions came up:

OTLP

https://github.com/open-telemetry/opentelemetry-proto/blob/81a296f9dba23e32d77f46d58c8ea4244a2157a6/opentelemetry/proto/common/v1/common.proto#L28-L40

Website (source)

image
tigrannajaryan commented 1 year ago

Logs require it: https://opentelemetry.io/docs/specs/otel/logs/data-model/#type-any

There is an open spec issue to allow traces and metrics to also use KeyValueList: https://github.com/open-telemetry/opentelemetry-specification/issues/376

bripkens commented 1 year ago

Awesome, thank you for the clarification @tigrannajaryan!