search

open-telemetry / opentelemetry-proto

OpenTelemetry protocol (OTLP) specification and Protobuf definitions
https://opentelemetry.io/docs/specs/otlp/
Apache License 2.0
606 stars 263 forks source link

Add W3C-specified trace flags to v1 Span proto #503

Closed jmacd closed 1 year ago

jmacd commented 1 year ago

As discussed in https://github.com/open-telemetry/opentelemetry-specification/issues/3411 and https://github.com/open-telemetry/opentelemetry-proto/issues/382, the OpenTelemetry Span object does not record the trace flags that were provided in its Trace Context.

For a tail sampler to sample spans using mechanism consistent with head sampling, the flags must be available in the protocol. W3C reserves 8 bits for these flags, of which two are defined. I've added 32-bit fields in the protocol for the span and the span link here.

jsuereth commented 1 year ago

Isn't this a duplciate of #384?

jmacd commented 1 year ago

Isn't this a duplciate of https://github.com/open-telemetry/opentelemetry-proto/pull/384?

Oh, yes!

jmacd commented 1 year ago

cc/ @blumamir I closed #384 in favor of this.

carlosalberto commented 1 year ago

@Oberon00 We are planning to merge this soon. Please take a last look, etc ;)