open-telemetry / opentelemetry-proto

OpenTelemetry protocol (OTLP) specification and Protobuf definitions

https://opentelemetry.io/docs/specs/otlp/

Apache License 2.0

545 stars 242 forks source link

Prepare release 1.1.0 #523

Closed bogdandrutu closed 5 months ago

tigrannajaryan commented 5 months ago

LGTM.

The only functional change since 1.0 is https://github.com/open-telemetry/opentelemetry-proto/pull/503 and it does not break stability guarantees, because it adds one field to existing message and adds a new enum. Both of this are explicitly allowed.

The release is a go.

carlosalberto commented 5 months ago

503 needs to be updated to the CHANGELOG btw. Do we want to hold this, in order to consider merging #484 and #514? Those two have been discussed enough (#484 needs final touches but overall seems good).

bogdandrutu commented 5 months ago

503 needs to be updated to the CHANGELOG btw.

What exactly?

Do we want to hold this, in order to consider merging https://github.com/open-telemetry/opentelemetry-proto/pull/484 and https://github.com/open-telemetry/opentelemetry-proto/pull/514? Those two have been discussed enough (https://github.com/open-telemetry/opentelemetry-proto/pull/484 needs final touches but overall seems good).

I would do another review next month instead of rushing things.

carlosalberto commented 5 months ago

Never mind on #503 - I had missed it.