Define relationship between profile messages and pprof

open-telemetry / opentelemetry-proto

OpenTelemetry protocol (OTLP) specification and Protobuf definitions

https://opentelemetry.io/docs/specs/otlp/

Apache License 2.0

545 stars 242 forks source link

Define relationship between profile messages and pprof #545

Open jack-berg opened 2 months ago

jack-berg commented 2 months ago

          Does this effectively represent a fork of the upstream definition [here](https://github.com/google/pprof/blob/main/proto/profile.proto)? It seems like it must be we likely have different versioning rules than whatever governs the upstream.

It seems valuable to have comments explaining the relationship between this file and upstream pprof.

_Originally posted by @jack-berg in https://github.com/open-telemetry/opentelemetry-proto/pull/534#discussion_r1552393303_

tigrannajaryan commented 2 months ago

@open-telemetry/profiling-maintainers It would be very useful to produce a diff between Otel profiles proto and pprof proto definitions and annotate the differences with explanations.