open-telemetry / opentelemetry-proto

OpenTelemetry protocol (OTLP) specification and Protobuf definitions
https://opentelemetry.io/docs/specs/otlp/
Apache License 2.0
606 stars 263 forks source link

Consider generalizing profile attributes optimization to other signals #546

Open jack-berg opened 7 months ago

jack-berg commented 7 months ago
          I don't disagree with this optimization, but its interesting that we choose to use it here and not elsewhere in the protocol. Wouldn't other signals, especially metrics, benefit from having a shared pool of attributes with points which reference those by index?

_Originally posted by @jack-berg in https://github.com/open-telemetry/opentelemetry-proto/pull/534#discussion_r1552409539_