search

open-telemetry / opentelemetry-proto

OpenTelemetry protocol (OTLP) specification and Protobuf definitions
https://opentelemetry.io/docs/specs/otlp/
Apache License 2.0
545 stars 242 forks source link

profiles: fix versioning in selector #551

Closed florianl closed 2 months ago

florianl commented 2 months ago

Creating Go dependencies for the Profiles signal fails, as the selector uses v1 instead of v1experimental.

$ docker run --rm -u 1000 -v/home/flehner/go/src/github.com/open-telemetry/opentelemetry-proto-go:/home/flehner/go/src/github.com/open-telemetry/opentelemetry-proto-go -w/home/flehner/go/src/github.com/open-telemetry/opentelemetry-proto-go otel/build-protobuf:0.23.0 --proto_path="gen/proto" --grpc-gateway_out=logtostderr=true,grpc_api_configuration=opentelemetry-proto/opentelemetry/proto/collector/profiles/v1experimental/profiles_service_http.yaml:./gen/go --go_out=./gen/go --go-grpc_out=./gen/go gen/proto/opentelemetry/proto/collector/profiles/v1experimental/profiles_service.proto
--grpc-gateway_out: HTTP rules without a matching selector: .opentelemetry.proto.collector.profiles.v1.ProfilesService.Export

I noticed this issue while working on https://github.com/open-telemetry/opentelemetry-proto-go/pull/166.

florianl commented 2 months ago

FYI @open-telemetry/profiling-maintainers

tigrannajaryan commented 2 months ago

Why didn't the build fail before this fix?

Nevermind, I see https://github.com/open-telemetry/opentelemetry-proto/pull/552 adds a check.