search

open-telemetry / opentelemetry-proto

OpenTelemetry protocol (OTLP) specification and Protobuf definitions
https://opentelemetry.io/docs/specs/otlp/
Apache License 2.0
545 stars 242 forks source link

Probably unintentional proto field ID gaps in the Sample message in pprofextended #562

Open aalexand opened 1 month ago

aalexand commented 1 month ago

Reordering things:

message Sample {
  repeated uint64 location_index = 1;
  repeated int64 value = 2;
  repeated Label label = 3;

  // fields 4, 5, 6 are missing.

  uint64 locations_start_index = 7;
  uint64 locations_length = 8;
  uint32 stacktrace_id_index = 9;
  repeated uint64 attributes = 10;

  // field 11 is missing

  uint64 link = 12;
  repeated uint64 timestamps_unix_nano = 13;
}

This seems unintentional.

@petethepig FYI