Renovations to experimental profiling schema.

open-telemetry / opentelemetry-proto

OpenTelemetry protocol (OTLP) specification and Protobuf definitions

https://opentelemetry.io/docs/specs/otlp/

Apache License 2.0

606 stars 263 forks source link

Renovations to experimental profiling schema. #596

Closed jhalliday closed 2 weeks ago

jhalliday commented 2 weeks ago

remove Profile keep_frames and drop_frames due to unclear semantics and use cases
make Sample.link_index and Location.mapping_index optional, consistent with documented intention
remove deprecated fields Sample.location_index, Mapping.id, Location.id, Function.id
renumber fields for improved redability

jhalliday commented 2 weeks ago

As discussed in the last profiling SIG meeting, this PR removes some unused or problematic fields and clarifies the optional use of others. The substantive changes are smaller than first appear, as the patch also reflows the remaining field numbers for increased clarity, which is somewhat noisy.