open-telemetry / opentelemetry-python-contrib

OpenTelemetry instrumentation for Python modules
https://opentelemetry.io
Apache License 2.0
699 stars 580 forks source link

Metrics instrumentation pymemcache #1152

Open srikanthccv opened 2 years ago

srikanthccv commented 2 years ago

DB semconv: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/database-metrics.md

rahulmukherjee68 commented 2 years ago

hey can you assign this to me.

rahulmukherjee68 commented 2 years ago

hey @srikanthccv I have some doubts related to semantic convention of db i am posting here feel free comment

  1. Is db.client.connections.usage for metric tells how many connection are currenlty in state of used or idle which can be set in upDownCounter ?

  2. what do you mean by db.client.connections.idle.max is it the maximum_pool value that is passed during pool intialization?

  3. db.client.connections.pending_requests can you please explain this pending request scenario?

srikanthccv commented 2 years ago

Is db.client.connections.usage for metric tells how many connection are currenlty in state of used or idle which can be set in upDownCounter ?

Yes

what do you mean by db.client.connections.idle.max is it the maximum_pool value that is passed during pool intialization?

Yes

db.client.connections.pending_requests can you please explain this pending request scenario?

Requests that are yet to be assigned with connection from the pool