open-telemetry / opentelemetry-python-contrib

OpenTelemetry instrumentation for Python modules
https://opentelemetry.io
Apache License 2.0
738 stars 609 forks source link

Make sure pymysql instrumentation follows semantic conventions #1628

Open srikanthccv opened 1 year ago

Anu-MT commented 1 year ago

Hi, I would like to work on the issue. Would you assign this to me?Any guidance will be greatly appreciated.

srikanthccv commented 1 year ago

pymysql instrumentation adds several attributes to the spans it creates. Some of them could be outside the semantic conventions defined for databases here https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/README.md. We need to update the instrumentation to follow the updated semantic conventions.

Joice-crypto commented 1 month ago

Hello, is anyone currently working on this? Could I give it a try?

emdneto commented 1 month ago

@Joice-crypto sure. Please feel free to open a PR