Lint is very slow. This mostly happens because we install every single package to create a virtual environment for linting.
We are using tox.ini files instead of a pure python alternative.
We use several bash scripts, instead of python scripts
We use a script (eachdist.py) to run a few actions, which I think they can be moved into noxfile.py files
We may be missing better tools to specify dependencies (like pipfile.lock files and such)
We install several unnecessary dependencies every time we want to test our packages
We may not be using the best tools or combination of tools for linting
tox.ini is very long. It is easy to overlook testing errors in this huge file, it has happened before.
In more high-level, architectural terms, I feel like we have a huge monorepo where lots of different packages exist and our infrastructure is designed in the same way. For example, we have a single tox.ini file where everything needed to test any package is added, instead of having different tox.ini files, one for every package. The latter approach is better in my opinion since it keeps these files smaller and relevant only for the package they would be in. I have noticed several errors in our tox.ini file that have been there for a long time, since they are very hard to detect just because of how big and complex this file is.
The main reasons we have this monorepo approach is because we test every commit in the core repo against the test cases in these repo and we test the packages in the contrib repo against a particular commit of the core repo.
To be clear, I am not suggesting a change in this testing approach. The issues and possible solutions I mention in this issue are separate and independent from this approach.
My intention with this particular issue is just to find a solution for the points above. Even if we fix them all, we can continue with the cloning-the-core-repo testing approach.
ocelotl
commented
4 months ago
I see several issues with our infrastructure:
tox.inifiles instead of a pure python alternative.eachdist.py) to run a few actions, which I think they can be moved intonoxfile.pyfilestox.iniis very long. It is easy to overlook testing errors in this huge file, it has happened before.In more high-level, architectural terms, I feel like we have a huge monorepo where lots of different packages exist and our infrastructure is designed in the same way. For example, we have a single
tox.inifile where everything needed to test any package is added, instead of having differenttox.inifiles, one for every package. The latter approach is better in my opinion since it keeps these files smaller and relevant only for the package they would be in. I have noticed several errors in ourtox.inifile that have been there for a long time, since they are very hard to detect just because of how big and complex this file is.The main reasons we have this monorepo approach is because we test every commit in the core repo against the test cases in these repo and we test the packages in the contrib repo against a particular commit of the core repo.
To be clear, I am not suggesting a change in this testing approach. The issues and possible solutions I mention in this issue are separate and independent from this approach.
My intention with this particular issue is just to find a solution for the points above. Even if we fix them all, we can continue with the cloning-the-core-repo testing approach.