open-telemetry / opentelemetry-python-contrib

OpenTelemetry instrumentation for Python modules
https://opentelemetry.io
Apache License 2.0
739 stars 613 forks source link

fix: remove opentelemetry-instrumentation-test package from bootstrap_gen #2969

Closed emdneto closed 2 weeks ago

emdneto commented 2 weeks ago

Description

Fixes #2968

rayrapetyan commented 2 weeks ago

Please consider adding a version specifier to https://github.com/open-telemetry/opentelemetry-python-contrib/blob/77613da39651e9406f163249c5cc90e6e226d964/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py#L164 first instead of removing opentelemetry-instrumentation-test package.

xrmx commented 2 weeks ago

Should this be listed as breaking change and write to remove that package to avoid conflicts in CHANGELOG?

emdneto commented 2 weeks ago

Please consider adding a version specifier to

https://github.com/open-telemetry/opentelemetry-python-contrib/blob/77613da39651e9406f163249c5cc90e6e226d964/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py#L164

first instead of removing opentelemetry-instrumentation-test package.

To not mix different things I prefer to fix sqlalchemy issue in another PR.