open-telemetry / opentelemetry-python-contrib

OpenTelemetry instrumentation for Python modules
https://opentelemetry.io
Apache License 2.0
739 stars 612 forks source link

adding gyliu513 as genai reviewer #2972

Closed gyliu513 closed 2 weeks ago

gyliu513 commented 2 weeks ago

Description

/cc @lmolkova @lzchen

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

karthikscale3 commented 2 weeks ago

@gyliu513 - i think you need to update the changelog

gyliu513 commented 2 weeks ago

There is no changelog for this.

karthikscale3 commented 2 weeks ago

There is no changelog for this.

ok not sure why the changelog test is failing though.

gyliu513 commented 2 weeks ago

@karthikscale3 are you able to add "Skip Changelog" label for this? If not, I think @lmolkova or @lzchen may help, thanks!

From https://github.com/open-telemetry/opentelemetry-python-contrib
 * branch            main       -> FETCH_HEAD
 * [new branch]      main       -> origin/main
No CHANGELOG was modified.
Please add a CHANGELOG entry, or add the "Skip Changelog" label if not required.
Error: Process completed with exit code 1.