open-telemetry / opentelemetry-python-contrib

OpenTelemetry instrumentation for Python modules
https://opentelemetry.io
Apache License 2.0
739 stars 612 forks source link

DB-API instrument_connection accepts optional connect_module #3027

Closed tammy-baylis-swi closed 1 day ago

tammy-baylis-swi commented 2 days ago

Description

DB-API instrument_connection accepts optional connect_module.

Should be merged before https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2942

Fixes https://github.com/open-telemetry/opentelemetry-python-contrib/issues/3028

Relates to https://github.com/open-telemetry/opentelemetry-python-contrib/issues/2902

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

aabmass commented 1 day ago

Thanks, I suppose testing here was thought about but considered too much code for what it is covering?

@tammy-baylis-swi any thoughts on this? I can merge once resolved

tammy-baylis-swi commented 1 day ago

Thanks, I suppose testing here was thought about but considered too much code for what it is covering?

@tammy-baylis-swi any thoughts on this? I can merge once resolved

Yeah more tests! I added some in 916bf5e. Let me know if any changes/more needed.