Instrumentations do not use `tracer_provider` argument to create a tracer instances

open-telemetry / opentelemetry-python-contrib

OpenTelemetry instrumentation for Python modules

https://opentelemetry.io

Apache License 2.0

733 stars 606 forks source link

Instrumentations do not use `tracer_provider` argument to create a tracer instances #401

Open srikanthccv opened 3 years ago

srikanthccv commented 3 years ago

Users can optionally pass an instance of TracerProvider to SomeInstrumentator.instrument(tracer_provider=...). Instrumentations should use this tracer_provider and fall back to global tracer provider if not given. As of now some instrumentations directly use global tracer provider which is not expected because providers can have different configuration such as Resource.

github-actions[bot] commented 3 years ago

This issue was marked stale due to lack of activity. It will be closed in 30 days.

lzchen commented 3 years ago

Remaining instrumentations: sklearn, pyramid and (perhaps) the logging instrumentation.