search

open-telemetry / opentelemetry-python

OpenTelemetry Python API and SDK
https://opentelemetry.io
Apache License 2.0
1.76k stars 614 forks source link

Remove [test] package from opentelemetry-exporter-otlp-proto-grpc #3746

Closed ocelotl closed 5 months ago

ocelotl commented 7 months ago

Fixes #3724

ocelotl commented 6 months ago

Tests are not passing, and I don't know why, reported it here. Marking it as draft in the meantime.

emdneto commented 6 months ago

Tests are not passing, and I don't know why, reported it here. Marking it as draft in the meantime.

@ocelotl In line 128 I think there is an invisible character at the beginning

grep "$(printf '\xEF\xBF\xBC')" tox.ini

matches: 

proto4-opentelemetry-exporter-otlp-proto-grpc: pip install -r {toxinidir}/exporter/opentelemetry-exporter-otlp-proto-grpc/test-requirements-1.txt

For me, removing the invisible character I was able to run tox -rvvve py38-proto4-opentelemetry-exporter-otlp-proto-grpc

ocelotl commented 5 months ago

Tests are not passing, and I don't know why, reported it here. Marking it as draft in the meantime.

@ocelotl In line 128 I think there is an invisible character at the beginning

grep "$(printf '\xEF\xBF\xBC')" tox.ini

matches:

proto4-opentelemetry-exporter-otlp-proto-grpc: pip install -r {toxinidir}/exporter/opentelemetry-exporter-otlp-proto-grpc/test-requirements-1.txt

For me, removing the invisible character I was able to run tox -rvvve py38-proto4-opentelemetry-exporter-otlp-proto-grpc

Whoah. This is incredible. I was totally out of answers. Thanks a lot @emdneto!