Open hennie-the-barbarian opened 6 months ago
1) The current target python version is 3.8, you'll need to use Optional
until we switch to something that supports https://peps.python.org/pep-0604/
2) There are a lot of to_json
functions around the codebase, which all currently share the same signature, which makes it "kind of" an interface, so I would say it should be a "none or all" type of a change.
I'm not a maintainer, so take it with a grain of salt.
Description
Changed the type of the indent argument in ReadableSpan to match the type signature of json.dumps, since indent is simply being passed through to json.dumps
Fixes # N/A
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
TBD as it's a simple change
Does This PR Require a Contrib Repo Change?
No
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
[ ] Yes. - Link to PR:
[x] No.
Checklist: