Closed euroelessar closed 7 months ago
cc: @ocelotl
Love the explanation near the code changes, thanks @euroelessar !
@srikanthccv thanks! can you recommend some other approver/maintainer to review this pr as well so it could be merged, please?
@ocelotl will do another review. He already assigned this to him.
Description
Fix various small issues in exponential histogram collection discovered by a newly added test and issues mentioned below:
self._scale
to be consistent with current bucket's scalescale
of the correct buckets alongside the buckets to method callsmin
,max
,sum
,count
,zero_count
values across collection callsindex_base
instead ofindex_start
, also take wrapping around the buffer into accountindex_start
and new index instead ofindex_end
index_start
matchesindex_base
Fixes #3393 Fixes #3600 Fixes #3562
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
[ ] Yes. - Link to PR:
[x] No.
Checklist: