open-telemetry / opentelemetry-python

OpenTelemetry Python API and SDK
https://opentelemetry.io
Apache License 2.0
1.76k stars 614 forks source link

Allow importlib_metadata < 8 #3804

Closed frenzymadness closed 6 months ago

frenzymadness commented 6 months ago

Description

importlib_metadata 7.1 is out. If you don't plan to update the configuration for every minor release, it might make sense to allow all versions 7.x.y. importlib_metadata is pretty stable so I'd not be afraid of any breaking changes.

tammy-baylis-swi commented 6 months ago

The existing strictness might relate to Python version differences discussed in https://github.com/open-telemetry/opentelemetry-python/issues/3234 and a similar open PR for the instrumentation library in https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2181. It might help to bring up this PR and these issues at the Python sig.

tammy-baylis-swi commented 6 months ago

Hi @frenzymadness , I brought this PR up at the Python SIG meeting today and we would prefer not to introduce a broad version support change at this time given the other issue and PR I've linked. I will close this but please feel free to bring up any questions or other ideas.

lzchen commented 6 months ago

@tammy-baylis-swi @frenzymadness

I think we would be okay with simply incrementing the version to cover v7.1 instead of the broader less than 8.

xrmx commented 6 months ago

Closing as superseded by https://github.com/open-telemetry/opentelemetry-python/pull/3835