open-telemetry / opentelemetry-python

OpenTelemetry Python API and SDK
https://opentelemetry.io
Apache License 2.0
1.76k stars 614 forks source link

Remove logs API proxy test's dependency on SDK #3812

Closed aabmass closed 6 months ago

aabmass commented 6 months ago

Description

The change is pretty self explanatory. API test shouldn't generally depend on the SDK and it was completely unnecessary here.

The Logger.emit() function shouldn't actually return anything, based on the ABC https://github.com/open-telemetry/opentelemetry-python/blob/29c293fbb120ff8b760519a25e0530b5ab05af83/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py#L100-L102

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

Checklist: