danielhochman commented 3 months ago

Description

Include the attribute key that failed to encode. Very hard to track down otherwise.

Before

Invalid type <class 'NoneType'> of value None

After

Failed to encode key namespace: Invalid type <class 'NoneType'> of value None

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Unit tests

Does This PR Require a Contrib Repo Change?

[x] No.

Checklist:

[x] Followed the style guidelines of this project
[x] Changelogs have been updated
[x] Unit tests have been added
[ ] Documentation has been updated

linux-foundation-easycla[bot] commented 3 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: lzchen / name: Leighton Chen (18280930e12a62c586c8fedad09760ccaf3dbe1c, b3f37b39c4781946f64f2a61efbb6c1c9eba6220)
:white_check_mark: login: danielhochman / name: Daniel Hochman (8378caff637c03bcd1c2d2978b586428a2c2ad55, 3a9d2c1df24ce7fe038a2f9e4183877505255e46, de1c4edff4c0feb57799a503d0cf7f9192a90191, 1667b0aac092d7c5ac416c91f7be3655577d931b, 8ed207c816fffca7d46a03ffa365a561cd0c63a5)
:white_check_mark: login: xrmx / name: Riccardo Magliocchetti (b6f6b484d72ccad18b2480f73da34b97ec799cae)

xrmx commented 2 months ago

@danielhochman you have to sign the CLA for contributing to OpenTelemetry

lzchen commented 1 week ago

@danielhochman

Please fix the build and add a CHANGELOG entry

open-telemetry / opentelemetry-python

log the attribute's key when encoding an attribute fails #3838

Description

Type of change

How Has This Been Tested?

Does This PR Require a Contrib Repo Change?

Checklist: