open-telemetry / opentelemetry-python

OpenTelemetry Python API and SDK
https://opentelemetry.io
Apache License 2.0
1.67k stars 569 forks source link

Record links with invalid SpanContext #3917

Closed emdneto closed 1 month ago

emdneto commented 1 month ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Implementations SHOULD record links containing SpanContext with empty TraceId or SpanId (all zeros) as long as either the attribute set or TraceState is non-empty.`

Fixes #3914

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

Checklist:

emdneto commented 1 month ago

Don't know why some tests from contrib-build are failing. I can't expand the run tox step to see the logs.

aiopg botocore tortoiseorm

lzchen commented 1 month ago

@emdneto

Thanks for the contribution!