Closed soumyadeepm04 closed 3 weeks ago
The committers listed above are authorized under a signed CLA.
Thanks -- I ran this change locally and it works fine for me.
Maybe someone else can weigh in here but I believe there are extra steps necessary because this file is mostly copied in contrib and so I believe this change will have to be manually applied there as well.
I'm going to open an issue to consolidate the eachdist logic between core and contrib.
Had a couple formatting and whitespace issues after the last change, fixed it in the new commit. The lint test should pass now. Thanks for your time.
Sure, would I have to create an issue there first before creating a PR?
Sure, would I have to create an issue there first before creating a PR?
I think a reference to this PR's issue is fine for now.
Description
Removed references to [test] packages from eachdist.py script. Fixes issue #3903.
Fixes #3903
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Ran
tox -e py311-opentelemetry-sdk
locallyDoes This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
[x] Yes.
[ ] No.
Checklist: