open-telemetry / opentelemetry-python

OpenTelemetry Python API and SDK
https://opentelemetry.io
Apache License 2.0
1.67k stars 569 forks source link

removed references to [test] packages from eachdist #3947

Closed soumyadeepm04 closed 3 weeks ago

soumyadeepm04 commented 3 weeks ago

Description

Removed references to [test] packages from eachdist.py script. Fixes issue #3903.

Fixes #3903

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Ran tox -e py311-opentelemetry-sdk locally

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

Checklist:

linux-foundation-easycla[bot] commented 3 weeks ago

CLA Signed

The committers listed above are authorized under a signed CLA.

pmcollins commented 3 weeks ago

Thanks -- I ran this change locally and it works fine for me.

Maybe someone else can weigh in here but I believe there are extra steps necessary because this file is mostly copied in contrib and so I believe this change will have to be manually applied there as well.

I'm going to open an issue to consolidate the eachdist logic between core and contrib.

soumyadeepm04 commented 3 weeks ago

Had a couple formatting and whitespace issues after the last change, fixed it in the new commit. The lint test should pass now. Thanks for your time.

soumyadeepm04 commented 3 weeks ago

Sure, would I have to create an issue there first before creating a PR?

pmcollins commented 3 weeks ago

Sure, would I have to create an issue there first before creating a PR?

I think a reference to this PR's issue is fine for now.