open-telemetry / opentelemetry-python

OpenTelemetry Python API and SDK

https://opentelemetry.io

Apache License 2.0

1.66k stars 568 forks source link

flask-debug-3933: update to set debug explicitly to False #3956

Closed keithkroeger closed 1 day ago

keithkroeger commented 3 weeks ago

Description

Change so that flask does not run in debug mode.

Fixes #3933

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Executed test suite

xrmx commented 1 week ago

@keithkroeger please fix conflict and next time please leave enabled the ability for maintainers to update your pr. Thanks!

xrmx commented 3 days ago

@keithkroeger ping, let's get this merged

keithkroeger commented 3 days ago

@keithkroeger ping, let's get this merged

I'm not authorized to merge but appreciate it if you can Thank you for the ping...resolved conflict on changelog

lzchen commented 3 days ago

@keithkroeger

Unfortunately everytime a different change is merged in, you will have to rebase and resolve any conflicts. If you change the pr to allow for one of the maintainers to fix the conflicts for you, you won't have to come back everytime for you to get this merged. I advise changing the permissions or creating a new PR, we can't hold off merging other prs.

keithkroeger commented 2 days ago

@keithkroeger

Unfortunately everytime a different change is merged in, you will have to rebase and resolve any conflicts. If you change the pr to allow for one of the maintainers to fix the conflicts for you, you won't have to come back everytime for you to get this merged. I advise changing the permissions or creating a new PR, we can't hold off merging other prs.

Thank you. I don't see where I can grant that permission for the PR nor do I see somewhere to grant contributors on this PR. I wonder if this is due to privs on my fork

Is there any way to allow auto merge?

ocelotl commented 2 days ago

@keithkroeger Unfortunately everytime a different change is merged in, you will have to rebase and resolve any conflicts. If you change the pr to allow for one of the maintainers to fix the conflicts for you, you won't have to come back everytime for you to get this merged. I advise changing the permissions or creating a new PR, we can't hold off merging other prs.

Thank you. I don't see where I can grant that permission for the PR nor do I see somewhere to grant contributors on this PR. I wonder if this is due to privs on my fork

Is there any way to allow auto merge?

I have enabled auto merge, I'm not sure if this will merge this PR automatically, because I have seen it disable itself as tests are being run. Does this help?

xrmx commented 1 day ago

@keithkroeger I don't think closing and reopening is helpful

keithkroeger commented 1 day ago

@keithkroeger I don't think closing and reopening is helpful I'm sorry, @xrmx I was trying to open a new one to see if there was some way to enable committers to update. But that option isn't available to me even on new PR. I'm sorry for the spamming, if some occurred