Closed lmolkova closed 2 weeks ago
@lmolkova please add a changelog entry, this is a good change to record
I think mypy build is complaining on the deprecated
decorators. Try passing the version="1.25.0"
directly.
@deprecated(
reason="Use :py:const:`opentelemetry.semconv._incubating.attributes.OsTypeValues` instead.",
version="1.25.0",
)
version="1.25.0",
the problem is that we don't know when the attribute was deprecated. I can only provide the current version (1.25.0
), but it'll be updated every time code is regenerated with new version and it won't be accurate.
We might add a property to track the version in the schema - https://github.com/open-telemetry/semantic-conventions/issues/1117 and then we'd be able to generate accurate docstring.
For the time being, I'd prefer to keep it empty and suppress the lint check.
Update: @deprecated(reason="...", version="...")
still raises a warning 🤷♀️
@lmolkova
I'm okay with ignoring the mypy warnings for deprecated.
Description
Prepares tooling to allow https://github.com/open-telemetry/opentelemetry-python/pull/3964:
os
andnet
namespaces from being generatedType of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
[ ] Yes. - Link to PR:
[ ] No.
Checklist: