search

open-telemetry / opentelemetry-python

OpenTelemetry Python API and SDK
https://opentelemetry.io
Apache License 2.0
1.66k stars 568 forks source link

PR instructions miss a small step #3969

Closed Charlie-lizhihan closed 1 week ago

Charlie-lizhihan commented 2 weeks ago

Describe your environment

No response

What happened?

Here is the part of contribution.md

Pull Requests
How to Send Pull Requests
Everyone is welcome to contribute code to opentelemetry-python via GitHub pull requests (PRs).

To create a new PR, fork the project in GitHub and clone the upstream repo:

$ git clone https://github.com/open-telemetry/opentelemetry-python.git
Add your fork as an origin:

$ git remote add fork https://github.com/YOUR_GITHUB_USERNAME/opentelemetry-python.git

before this step: $ git remote add fork https://github.com/YOUR_GITHUB_USERNAME/opentelemetry-python.git

we should add a new step, jump in to the folder you just create, bcz it will not jump to it automatically

Steps to Reproduce

no need

Expected Result

detailed steps

Actual Result

not detail enough

Additional context

No response

Would you like to implement a fix?

Yes

pmcollins commented 1 week ago

Thank you for the fix @Charlie-lizhihan. Closing.