Open pirgeo opened 6 days ago
I tried to align with the other examples, which all have requirements.txt files. I don't have a preference for either, so I am happy to change it to simply adding it to the readme.
I tried to align with the other examples, which all have requirements.txt files. I don't have a preference for either, so I am happy to change it to simply adding it to the readme.
Given the status of these requirements I think I have a stronger opinion now :sweat_smile: But let's see what maintainers think.
I tried to align with the other examples, which all have requirements.txt files. I don't have a preference for either, so I am happy to change it to simply adding it to the readme.
Given the status of these requirements I think I have a stronger opinion now 😅 But let's see what maintainers think.
+1 for this, less maintenence the better :)
I suggest we keep the requirements.txt
file, just remove the pinned versions.
I updated it to use >=
instead of ==
. Please let me know if you think this works, otherwise I'll just drop the versions completely!
@ocelotl
I suggest we keep the requirements.txt file, just remove the pinned versions.
We don't requirements.txt file for the examples. Do we really want to start adding them for each example? This seems like more maintenance overhead.
Description
Adds missing
requirements.txt
for one example (https://github.com/open-telemetry/opentelemetry-python/tree/main/docs/examples/metrics/instruments).Type of change
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: