search

open-telemetry / opentelemetry-python

OpenTelemetry Python API and SDK
https://opentelemetry.io
Apache License 2.0
1.81k stars 631 forks source link

infra: reduce toil of manually sync workflows between contrib and core (generate-workflows-lib) #4263

Open emdneto opened 1 week ago

emdneto commented 1 week ago

Frequently we face situations when we change tox.ini in contrib (e.g., adding a new env or instrumentation or fixing a env name) we are required to manually update workflows in core as well (we need this to test core changes don't break contrib). Here are some PRs:

https://github.com/open-telemetry/opentelemetry-python/pull/4258 https://github.com/open-telemetry/opentelemetry-python/pull/4256 https://github.com/open-telemetry/opentelemetry-python/pull/4239 https://github.com/open-telemetry/opentelemetry-python/pull/4192 https://github.com/open-telemetry/opentelemetry-python/pull/4158

Maybe there's a better way to do that without the need to wait someone deal with a broken PR in core because tox -e generate-workflows is failing in CI.

Right now, the solution is: we need to manually fix workflows (i.e., run tox -e generate-workflows locally) and commit the changes (this is the process for keep workflows synced between -core and -contrib).

  1. We need to have this explicit in documentation as well.
  2. Investigate better way to automate this.
xrmx commented 5 days ago

I think this is similar to https://github.com/open-telemetry/opentelemetry-python-contrib/issues/2965 and that a fix for one will fix the other too.