open-telemetry / opentelemetry-python

OpenTelemetry Python API and SDK
https://opentelemetry.io
Apache License 2.0
1.82k stars 635 forks source link

Remove TestBase assertEqualSpanInstrumentationInfo when no longer used #4301

Open tammy-baylis-swi opened 5 days ago

tammy-baylis-swi commented 5 days ago

Is your feature request related to a problem?

Yes, https://github.com/open-telemetry/opentelemetry-python-contrib/issues/3033

Describe the solution you'd like

It would be nice if we could remove assertEqualSpanInstrumentationInfo because it results in deprecation warnings. See contrib issue https://github.com/open-telemetry/opentelemetry-python-contrib/issues/3033

Maybe we could do this step-wise:

  1. Remove all contrib uses (https://github.com/open-telemetry/opentelemetry-python-contrib/issues/3033)
  2. There doesn't seem to be any core uses (grep)
  3. For a few releases, have assertEqualSpanInstrumentationInfo log warnings that it will be removed in a future release.
  4. Remove assertEqualSpanInstrumentationInfo.

Describe alternatives you've considered

Or keep it forever?

Additional Context

n/a

Would you like to implement a fix?

Yes

tammy-baylis-swi commented 5 days ago

I think this should be a contrib issue instead. Closing.

Work on https://github.com/open-telemetry/opentelemetry-python-contrib/issues/3033 first.