open-telemetry / opentelemetry-ruby-contrib

Contrib Packages for the OpenTelemetry Ruby API and SDK implementation.
https://opentelemetry.io
Apache License 2.0
80 stars 164 forks source link

Changes Requested for ActiveSupport instrumentation #957

Open arielvalentin opened 4 months ago

arielvalentin commented 4 months ago

During the SIG meeting on 2024-04-30, I brought up a few challenges of working with the existing ActiveSupport instrumentation, that were brought to our attention while instrumenting ActionMailer: https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/887

There were issues with missing options, implementation and naming that makes it difficult to use and potentially error prone. The list below includes some of the changes I would like to see:

github-actions[bot] commented 3 months ago

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.