search

open-telemetry / opentelemetry-ruby

OpenTelemetry Ruby API & SDK, and related gems
https://opentelemetry.io/
Apache License 2.0
493 stars 244 forks source link

Metrics: Implement Advisory Parameters #1686

Open kaylareopelle opened 3 months ago

kaylareopelle commented 3 months ago

To help update bucket boundaries for instruments in instrumentation, implement advisory parameters (AKA advice)

API: https://opentelemetry.io/docs/specs/otel/metrics/api/#instrument-advisory-parameters SDK: https://opentelemetry.io/docs/specs/otel/metrics/sdk/#instrument-advisory-parameters JS implementation example: https://github.com/open-telemetry/opentelemetry-js/pull/3876 JS instrumentation example: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/770130a7a41125dbf8a8c18b3384e5fcc370deef/plugins/node/instrumentation-undici/src/undici.ts#L127-L141

kaylareopelle commented 3 months ago

Right now, just working on the explicit bucket boundaries advisory parameter. Attributes is marked as experimental. Checking in on https://github.com/open-telemetry/opentelemetry-specification/issues/3785 to see if it's stable enough to implement.

github-actions[bot] commented 2 months ago

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

github-actions[bot] commented 3 weeks ago

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.