open-telemetry / opentelemetry-ruby

OpenTelemetry Ruby API & SDK, and related gems
https://opentelemetry.io/
Apache License 2.0
488 stars 239 forks source link

Metrics reader supports configuring aggregation and temporality #1723

Open kaylareopelle opened 1 month ago

kaylareopelle commented 1 month ago

The metrics Reader implementation should support configuring the default aggregation and the default temporality on the basis of instrument kind. There are two lines on the spec compliance matrix about this.

This may be the relevant spec: https://opentelemetry.io/docs/specs/otel/metrics/sdk/#metricreader

Our aggregation classes set the temporality and it can be configured using an environment variable, OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE

Our instruments have a default temporality and don't have a public-facing API to change their aggregation. We should look at the configuration options for aggregation and temporality and see if they are compliant. If they are not, update the SDK to make it compliant.

github-actions[bot] commented 3 weeks ago

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.