open-telemetry / opentelemetry-rust-contrib

OpenTelemetry Contrib Packages for Rust
Apache License 2.0
35 stars 34 forks source link

resource-detectors: add support for host ID detection on macOS #73

Closed djc closed 4 months ago

djc commented 4 months ago

Changes

Implement host_id_detect() for macOS per the spec.

Output from cargo test -- --nocapture:

[opentelemetry-resource-detectors/src/host.rs:114:9] &resource = Resource {
    inner: ResourceInner {
        attrs: {
            Static(
                "host.id",
            ): String(
                Owned(
                    "60F28E1A-C070-5873-85C1-5ABC138C66B9",
                ),
test host::tests::test_resource_host_arch_value ...     ok
        ),
            Static(
                "host.arch",
            ): String(
                Static(
                    "aarch64",
                ),
            ),
        },
        schema_url: None,
    },
}

Merge requirement checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.0%. Comparing base (56a6f45) to head (78d6bf8). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #73 +/- ## ======================================== - Coverage 52.3% 41.0% -11.3% ======================================== Files 38 27 -11 Lines 4967 3294 -1673 ======================================== - Hits 2598 1351 -1247 + Misses 2369 1943 -426 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.