open-telemetry / opentelemetry-rust

The Rust OpenTelemetry implementation
https://opentelemetry.io
Apache License 2.0
1.72k stars 386 forks source link

Signal feature flag name is not consistent #1710

Open cijothomas opened 2 months ago

cijothomas commented 2 months ago

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/Cargo.toml#L35

We use "trace", "logs", "metrics". Proposing to make it consistent and rename "trace" to "traces".

https://opentelemetry.io/docs/concepts/signals/

lalitb commented 2 months ago

We use "trace", "logs", "metrics". Proposing to make it consistent and rename "trace" to "traces".

The namespaces are opentelemetry::trace, opentelemetry_sdk::trace in implementation, so trace actually makes sense from that regards.