What should provider's force_flush return

open-telemetry / opentelemetry-rust

The Rust OpenTelemetry implementation

https://opentelemetry.io

Apache License 2.0

1.82k stars 424 forks source link

What should provider's force_flush return #1751

Open cijothomas opened 4 months ago

cijothomas commented 4 months ago

We can return an overall Result Return a Vec of results from each processor/reader.

We need to be consistent across signals, unless there is a good reason to deviate.

originally discussed in : https://github.com/open-telemetry/opentelemetry-rust/pull/1750#discussion_r1598797883

cijothomas commented 4 months ago

From SIG meeting on 5/14

Make force_flush return Vec! of Results from each processor (logs,traces), reader (metrics). The order in which processors are invoked are not guaranteed. (explicitly document this) The error message should be standardized so it'll be possible to tell which processor/reader is failed. Failing to flush one should not affect the rest.