search

open-telemetry / opentelemetry-specification

Specifications for OpenTelemetry
https://opentelemetry.io
Apache License 2.0
3.66k stars 880 forks source link

Metric names in specification don't match hostmetrics's paging scraper #2727

Open crobert-1 opened 1 year ago

crobert-1 commented 1 year ago

Metric names should be consistent between specification and receiver scrapers. The metrics in question are from the hostmetrics receiver, specifically the paging scraper: system.paging.operations.page_in and system.paging.operations.page_out. The specification incorrectly labels these as system.paging.operations.in and system.paging.operations.out. I believe the README and code are correct and the specification needs to be updated to match, but I'm open to correction here.

The mismatch appeared as a part of the direction attribute removal for the paging scraper.

Specification hostmetrics receiver paging scraper README Relevant code showing page_in and page_out

rbailey7210 commented 1 year ago

Thank you for reporting this. Would you be willing to follow-up?

crobert-1 commented 1 year ago

I'm unsure how to proceed based on #2726. It looks like discussion is going on to may revert these changes and revisit the metric format change. Reverting the changed would resolve this issue.

I think it may be best to wait and see what happens with the metric format change as a whole before fixing.

jmacd commented 1 year ago

Yes, it looks like we will revert all changes stemming from the change of "direction", which I think means reverting the name change here.