search

open-telemetry / opentelemetry-specification

Specifications for OpenTelemetry
https://opentelemetry.io
Apache License 2.0
3.71k stars 887 forks source link

Exemplars SHOULD be on by default #3994

Closed reyang closed 5 months ago

reyang commented 5 months ago

Unblocks #3870

Changes

Discussed during the Apr. 10th, 2024 Technical Committee Meeting, we'd like to move Exemplars specification to stable. To address the blocking concern https://github.com/open-telemetry/opentelemetry-specification/pull/3870#pullrequestreview-1952842576, this PR updated the wording to "SHOULD be on" (instead of "MUST be on"), if certain SDK implementations have performance concerns, they can decide to ship a stable version with exemplars OFF by default, and switch to ON by default later once the perf issue is solved (which is not a breaking change as exemplars are best efforts).

cijothomas commented 5 months ago

this PR updated the wording to "SHOULD" (instead of "MUST"),

From what I can tell... this was already a SHOULD! Did I miss something obvious?