Closed CodeBlanch closed 4 months ago
This PR was marked stale due to lack of activity. It will be closed in 7 days.
I don't think Views are the right solution for this level of granularity. From the specification call:
Would prefer to see this configuration on MetricReader, similar to temporal aggregation.
This PR was marked stale due to lack of activity. It will be closed in 7 days.
Closed as inactive. Feel free to reopen if this PR is still being worked on.
Changes
ExemplarFilter
via the View APIDetails
In .NET we have decided to NOT enable
Exemplar
s by default due to performance considerations. If users wantExemplar
s they can set anExemplarFilter
at theMeterProvider
level. This will carry a performance hit for all measurements.We feel users may only want to pay for the performance hit on critical metrics. With the current specification design, users don't have a lot of options to accomplish this. Really the only thing which may be done is enable
Exemplar
s for theMeterProvider
and then use the View API to set anExemplarReservoir
which dropsExemplar
s for any/all metrics where they aren't desired.The proposed addition here is seeking to make it easier to selectively enable or disable
Exemplar
s at the instrument-level.For non-trivial changes, follow the change proposal process.
CHANGELOG.md
file updated for non-trivial changesspec-compliance-matrix.md
updated if necessary