open-telemetry / opentelemetry-specification

Specifications for OpenTelemetry
https://opentelemetry.io
Apache License 2.0
3.76k stars 890 forks source link

Event identifier of an integer type #4278

Open pellared opened 3 weeks ago

pellared commented 3 weeks ago

What are you trying to achieve?

It may be good to allow having EventId of an integer type (instead of EventName which is always as string) for performance reasons.

Additional context.

In .NET the EventId is a integer with optional name. https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging.eventid.-ctor?view=net-8.0

Also see OTel C++:

Related to:

pellared commented 3 weeks ago

I created this issue as I think it was brought up a few times.

My personal opinion, is that for sake of simplicity we should only have Event Name as string for the identifier. The reason is that it is the model of OpenTelemetry Events and not any possible event system/library/software. The OTel Semantic Conventions are using names.

trask commented 2 weeks ago

removed tc-inbox label since it's a sig-issue

cijothomas commented 6 days ago

Linking to prior attempts at having a durable identified for Logs(Events): https://github.com/open-telemetry/semantic-conventions/issues/372 https://github.com/open-telemetry/semantic-conventions/pull/1339