Update Binary format in the Specification

open-telemetry / opentelemetry-specification

Specifications for OpenTelemetry

https://opentelemetry.io

Apache License 2.0

3.76k stars 890 forks source link

Update Binary format in the Specification #437

Closed carlosalberto closed 4 months ago

carlosalberto commented 4 years ago

As https://github.com/open-telemetry/opentelemetry-specification/pull/426 is temporarily removing Binary format, we need to make sure Binary is re-added and updated properly with the OTEP 66 updates.

Assigning for now to @MikeGoldsmith but we can discuss who can tackle this item going forward.

bogdandrutu commented 4 years ago

Added @carlosalberto to the assignees since he promised to add it back :)

carlosalberto commented 4 years ago

That works :)

Oberon00 commented 4 years ago

Can we assign a milestone for this issue? Any release that wants to offer a full OpenTracing or OpenCensus compatibility layer will need this feature.

Oberon00 commented 4 years ago

Also, we need that feature at Dynatrace and will have to stay on an older version of the Java API until this is fixed.

carlosalberto commented 4 years ago

@Oberon00 So the milestone would be 0.5.0 - for which we don't have a date for yet (other than being the next important milestone). Maybe we need to discuss this in the next SIG/community call, to plan what/how happens after beta ;)

andrewhsu commented 4 years ago

Talked with @carlosalberto today and based on the history of the intention of binary format (it looks like it was only desired to be temporarily removed), looks like this one is important to get in sooner because it can cause backward breaking change. Therefore, changing priority to p1.

andrewhsu commented 4 years ago

from the spec issue triage mtg today, discussed this and moving to after ga

annabokhan commented 8 months ago

Documentation states that the binary propagator support is upcoming, however this thread has been stale for almost 4 years. Is this still planned?

amalgawa commented 7 months ago

+1 to above question. It has been 4 years, since no activity. If there are any prior investigations why it was no longer pursued, I can probably help implement it.

svrnm commented 7 months ago

@carlosalberto what is the status of this one?

esemeniuc commented 5 months ago

+1 need to see this

jack-berg commented 4 months ago

Discussed in the 7/17/24 TC meeting. We're closing this for the time being for:

niche use case / low demand
lack of performance benchmarks indicating benefit
protocols really need binary support baked in
seems more appropriate to drive at W3C level, and that effort has delayed and stalled

If the W3C binary traceparent effort picks back up, we should re-open this issue and implement in OpenTelemetry.