search

open-telemetry / opentelemetry-sqlcommenter

SQLCommenter components for various languages
Apache License 2.0
28 stars 13 forks source link

Remove Flask related documents #13

Closed ymotongpoo closed 2 years ago

ymotongpoo commented 3 years ago

Fixes #12

ymotongpoo commented 3 years ago

@sjs994 Thanks for pointing it out. I also removed the section that mentions non-existing features for Flask.

sjs994 commented 3 years ago

Thanks Yoshi,

I just checked now, there seems to be another way to instrument flask with sqlalchemy and psycopg2.

Should we update that in the document ?

ymotongpoo commented 3 years ago

@sjs994 Thanks for checking it. I should have checked the implementation more thoroughly. With your comment, I realized that the issue is that sqlcommenter is just lacking the implementation FlaskMiddleware and auto detection of some attributes by get_flask_info() is available. I'll take this into this PR.

ymotongpoo commented 2 years ago

@sjs994 Sorry for delayed update! I made some changed to match the description with the current implementations.

ymotongpoo commented 2 years ago

@sjs994 Thanks for the comment. I agree your points. I reverted the Flask logo into the READMEs of psycopg2 and SQLAlchemy .