Open Thiyagu55 opened 2 years ago
I can see this working :)
To give some context: This is a monorepo with multiple languages. So a normal release would:
What we were thinking with this PR is
sqlcommenter-python/**
on merging would trigger a workflow to copy the content into python-sqlcommenter
branch.@aabmass @lonewolf3739 Do you guys see any concerns with this approach ?
I don't see any immediate concerns with this approach. Since there is one workflow for each lang would it be possible to do this in main branch itself?
I don't see any immediate concerns with this approach. Since there is one workflow for each lang would it be possible to do this in main branch itself?
yes, we can do it from main branch but it has its pros and cons.
if tag like 'java-sqlcommenter-%' use java-workflow.yml
.
With this, we can release particular language library, but still our release assets will contains the whole code as we don't have control on what to add to assets.Now, this approach of creating release from branches would mitigate the assets part, where python release would only contain python sources and so for other languages.
But there is one problem with this approach, that is the release branch by default allow git push
directly. Anyone can push changes to that. If we lock it, github actions can't force push the changes automatically and would require robot account
to make those branches secure. Exploring if there are other ways like using a DEPLOY_TOKEN