search

open-telemetry / opentelemetry-swift

OpenTelemetry API for Swift
https://opentelemetry.io/docs/instrumentation/swift/
Apache License 2.0
222 stars 145 forks source link

Fix crash when auto instrumenting AVAsset download task #452

Closed nachoBonafonte closed 1 year ago

nachoBonafonte commented 1 year ago

Skip tasks that are of kind of AVAssetDownloadTask. Most of the changes are Swift formatting changes, real fix starts in line 575

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 82.22% and no project coverage change.

Comparison is base (648dbba) 66.37% compared to head (664e21d) 66.38%.

:exclamation: Current head 664e21d differs from pull request most recent head 9cad2ce. Consider uploading reports for the commit 9cad2ce to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #452 +/- ## ======================================= Coverage 66.37% 66.38% ======================================= Files 331 331 Lines 14113 14117 +4 ======================================= + Hits 9367 9371 +4 Misses 4746 4746 ``` | [Files Changed](https://app.codecov.io/gh/open-telemetry/opentelemetry-swift/pull/452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...ntation/URLSession/URLSessionInstrumentation.swift](https://app.codecov.io/gh/open-telemetry/opentelemetry-swift/pull/452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-U291cmNlcy9JbnN0cnVtZW50YXRpb24vVVJMU2Vzc2lvbi9VUkxTZXNzaW9uSW5zdHJ1bWVudGF0aW9uLnN3aWZ0) | `67.65% <82.22%> (+0.22%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nachoBonafonte commented 1 year ago

Fixes #447