search

open-telemetry / opentelemetry-swift

OpenTelemetry API for Swift
https://opentelemetry.io/docs/instrumentation/swift/
Apache License 2.0
221 stars 145 forks source link

Fix the order of initialization between DoubleHistogram and LongHistogram #474

Closed hunguyenaxon closed 1 year ago

hunguyenaxon commented 1 year ago

The fix is for https://github.com/open-telemetry/opentelemetry-swift/issues/470

Both kind of instrument build sdk should have the same order: instrumentName, description, unit. It then allows the swapBuilder(...) perform correctly

codecov[bot] commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...etrics/Stable/DoubleHistogramMeterBuilderSdk.swift 80.00% <100.00%> (ø)
.../Metrics/Stable/LongHistogramMeterBuilderSdk.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!.